[CM-1955] Expose Dynamic online/offline status update method #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhijeetRanjan308
changed the title
Sathyan-KM
requested changes
Mar 11, 2024
Comment on lines
113
to
114
| final String AssigneeID = updateStatusObjc.get("assigneID").toString(); | ||
| final String Status = updateStatusObjc.get("status").toString(); |
There was a problem hiding this comment.
check final naming convention
Comment on lines
120
to
150
| if (AssigneeID.isEmpty()) { | ||
| switch (Status.toLowerCase()) { | ||
| case "online": | ||
| Kommunicate.updateAssigneeStatus("", KMAgentStatusHelper.KMAgentStatus.ONLINE); | ||
| break; | ||
| case "offline": | ||
| Kommunicate.updateAssigneeStatus("", KMAgentStatusHelper.KMAgentStatus.OFFLINE); | ||
| break; | ||
| case "away": | ||
| Kommunicate.updateAssigneeStatus("", KMAgentStatusHelper.KMAgentStatus.AWAY); | ||
| break; | ||
| default: | ||
| Kommunicate.updateAssigneeStatus("", KMAgentStatusHelper.KMAgentStatus.DefaultStatus); | ||
| break; | ||
| } | ||
| } else { | ||
| switch (Status.toLowerCase()) { | ||
| case "online": | ||
| Kommunicate.updateAssigneeStatus(AssigneeID, KMAgentStatusHelper.KMAgentStatus.ONLINE); | ||
| break; | ||
| case "offline": | ||
| Kommunicate.updateAssigneeStatus(AssigneeID, KMAgentStatusHelper.KMAgentStatus.OFFLINE); | ||
| break; | ||
| case "away": | ||
| Kommunicate.updateAssigneeStatus(AssigneeID, KMAgentStatusHelper.KMAgentStatus.AWAY); | ||
| break; | ||
| default: | ||
| Kommunicate.updateAssigneeStatus(AssigneeID, KMAgentStatusHelper.KMAgentStatus.DefaultStatus); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we use single switch case without if & else & a variable to handle the nullability of assignee ID
Comment on lines
+139
to
+141
| if status.isEmpty { | ||
| self.sendErrorResult(message: "Status is Empty.") | ||
| return |
There was a problem hiding this comment.
use another guard let for status empty check & variable for assigneeid . And then use it in a single switch
There was a problem hiding this comment.
Not required already have a check above this
Sathyan-KM
approved these changes
Mar 11, 2024
Sathyan-KM
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code
Parameters