Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: [homing_heaters] not working with heater_generic #6623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whyme12
Copy link

@whyme12 whyme12 commented Jun 20, 2024

Module: heaters: [homing_heaters] not working with heater_generic.

Currently the heater in [homing_heaters] has to be set as heater_generic my_heater
while on a homing or probing move it is checked for the heater name my_heater,
which can't be found.
With this fix, the config check requires my_heater to be defined which matches the later
check when homing or probing
As far as I can tell, no impact on other things, as get_all_heaters() is only used in homing_heaters.py.

Signed-off-by: Robin Ehnert [email protected]

When using heater_generic in [homing_heaters] klipper will run into an exception due to a parsing error.

The heater in [homing_heaters] has to be set as `heater_generic my_heater` while on a homing or probing move it is checked for the heater name `my_heater`, which can't be found.
Copy link

github-actions bot commented Jul 4, 2024

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant