-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bed_mesh: add support for "rapid" scanning #6617
bed_mesh: add support for "rapid" scanning #6617
Conversation
Thanks. I cherry-picked your gcc-pru build patch. This PR seems good to me. I think we should give a few days for others to comment, but otherwise I'm ready to commit when you are. Not a "blocker", but have you considered using a webhooks endpoint instead of the BED_MESH_DUMP command (and have Thanks again, |
Instead of directly calling axis_twist_compensation, send an event that can perform the necessary updates. Signed-off-by: Kevin O'Connor <[email protected]>
10ba63d
to
6d4cdb1
Compare
I think this is a good idea. I'll rework |
👍 this works great |
Add a scanning mode that does not require pausing the toolhead at each probe point. Signed-off-by: Kevin O'Connor <[email protected]>
This adds supplemental path generation that implements "overshoot" when a change of direction is performed during a rapid scan. This overshoot reduces measurement error at the extremes of the mesh along the X axis. Signed-off-by: Eric Callahan <[email protected]>
06a650a
to
d89a669
Compare
I have removed the
The json file can be created with the |
Thanks. It looks good to me. If there are no further comments, I'll look to commit in a couple of days. -Kevin |
klippy/extras/bed_mesh.py
Outdated
@@ -282,6 +287,32 @@ def cmd_BED_MESH_OFFSET(self, gcmd): | |||
gcode_move.reset_last_position() | |||
else: | |||
gcmd.respond_info("No mesh loaded to offset") | |||
cmd_BED_MESH_DUMP_help = "Dump mesh data to file for analysis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor - dead line of code?
-Kevin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Should be fixed now.
Returns current mesh configuration and state. Includes probed and mesh matrices, saved profiles, current points, and travel paths. Signed-off-by: Eric Callahan <[email protected]>
Signed-off-by: Eric Callahan <[email protected]>
The scan modes provide kinematic XYZ coordinates in the probe results. These positions may deviate from the requested positions, which can introduce errors in mesh generation when transposing the result into the Z matrix. Rely on the coordinates generated by bed mesh to transpose the matrix, presuming that points at the same index in the list match. Signed-off-by: Eric Callahan <[email protected]>
In addition, do not respond with generated points. Signed-off-by: Eric Callahan <[email protected]>
Signed-off-by: Eric Callahan <[email protected]>
d89a669
to
fa5342f
Compare
Thanks! -Kevin |
Question, are there more patches to get the BTT Eddy to work on the official Klipper branch or is this it? |
There are a number of features that have been discussed or are in progress. Here's my understanding of the status:
I expect the above is what most users will expect. There are a few things in discussion that are not in mainline:
Hope that helps, |
Absolutely, in this case I'll stick to the BTT branch for the time being, specially due to the homing feature. |
This pull request builds on #6610, adding support for optimized travel paths when a
rapid_scan
is requested. In addition, theprobe_finalize()
method no longer depends on on the XY coordinates received from the probing procedure to populate the Z matrix.The final commit in this series updates
gnupru
to the latest release inci-install.sh
. It appears that version2023.1
fails due to a missing dependency.