Add UserAgent attribute in ComapSmartHome API calls #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, COMAP developer here again!
We made a few security changes this morning on our APIs that broke Jeedom plugin (sorry for that 馃槄). I did rollback the changes for the moment but we will enforce these security changes in the near future.
It seems that the rule that blocked the calls was from a list of common security ruleset (rule #NoUserAgent_HEADER) so I made the changes in the comapAPI file (also not tested, sorry). I'm not completely sure if the requests you are currently performing will pass all the new security rules. We have a development environment completely decoupled from the production one where we are deploying new changes to test before production release. If you want to use it to validate the requests before the next security changes, I can help you set it up.
On another note, I made a little change on the error message since we have some Jeedom plugin users that thinks that Qivivo API is still alive and used in the plugin. The Qivivo name is not really used anymore, we changed it definitively to ComapSmartHome a few years ago when we developed the new platform and APIs so you might want to change references to this name, at least in the strings that users can really see to prevent further incomprehension.
Have a nice day!