Fix shader argument buffer padding and atomics. #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2024
cdavis5e
approved these changes
May 6, 2024
|
For the record, the SPIRV-Cross change looks good, too. |
Normally I would. With the SDK release coming up, it was a bit of a rush to get everything sorted out. So to expedite, I thought I'd get the SPRIV-Cross MoltenVK branch set up, and populated here, so they could be reviewed together. If it didn't work out, I could then just delete the SPIRV-Cross branch. All part of my master plan! 😂 |
billhollings
force-pushed
the
fix-arg-buff-padding
branch
from
932544d
to
d0b3b2e
Compare
billhollings
changed the title
|
I've updated this to include the fix for the atomic issue in #2216, and to use the new commit hash from the |
- Pull in SPIRV-Cross fix for argument buffer padding. - Only use MTLTextureUsageShaderAtomic if native atomics are supported on the platform.
billhollings
force-pushed
the
fix-arg-buff-padding
branch
from
d0b3b2e
to
7167eaf
Compare
cdavis5e
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTLTextureUsageShaderAtomicif native atomics are supported on the platform.Fixes issues #2216 and #2180.