Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Persist URL query params #9

Merged
merged 5 commits into from
Feb 3, 2017
Merged

Persist URL query params #9

merged 5 commits into from
Feb 3, 2017

Conversation

seanjh
Copy link
Member

@seanjh seanjh commented Jan 27, 2017

No description provided.

@seanjh
Copy link
Member Author

seanjh commented Jan 28, 2017 •
edited
Loading

  • Can get bad query parameters on browser navigation (e.g., &page=1)
  • Location filter container needs to handle mount and new props
  • Need some way to exclude null/undefined push query parameters, or a way to remove an individual query parameter.

@seanjh
Copy link
Member Author

seanjh commented Feb 1, 2017 •
edited
Loading

  • Duplicate state updates from query parameter parser container
  • The location selection occasionally "sticks"
  • Remove debug logging
  • Handle the page query parameter
  • Cleanup references to watchRouter

seanjh
seanjh commented Feb 3, 2017
View reviewed changes
app/client/containers/LocationFiltersContainer.jsx Outdated
filterFacilityKey: state.summaryFilter.get('facilityKey', null),
filteredMetaFacilities: getFilteredMetaFacilities(state),
filterRegionKey: state.summaryFilter.get('regionKey', null),
metaFacilitiesByKey: state.metaRegionsByKey,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old typo

@seanjh seanjh merged commit 8694a05 into master Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@seanjh