Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LEMS-1969): numeric input widget simplifying fractions too quickly #1347

Closed
wants to merge 12 commits into from

Conversation

anakaren-rojas
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 13, 2024

Size Change: +25 B (0%)

Total Size: 845 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 271 kB +25 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 407 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@anakaren-rojas anakaren-rojas marked this pull request as ready for review June 14, 2024 18:25
@khan-actions-bot khan-actions-bot requested a review from a team June 14, 2024 18:25
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jun 14, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to packages/perseus-editor/src/widgets/numeric-input-editor.tsx, packages/perseus-editor/src/widgets/__stories__/numeric-input-editor.stories.tsx, packages/perseus-editor/src/widgets/__tests__/numeric-input-editor.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@anakaren-rojas anakaren-rojas removed the request for review from a team June 14, 2024 18:26
@khan-actions-bot khan-actions-bot requested a review from a team June 14, 2024 18:44
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (49ea2a2) and published it to npm. You
can install it using the tag PR1347.

Example:

yarn add @khanacademy/perseus@PR1347

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1347

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (50c8233) to head (49ea2a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   69.77%   70.40%   +0.62%     
==========================================
  Files         488      492       +4     
  Lines      103276   103351      +75     
  Branches     7430    11097    +3667     
==========================================
+ Hits        72058    72761     +703     
+ Misses      31039    30590     -449     
+ Partials      179        0     -179     

Impacted file tree graph

Files Coverage Δ
...erseus-editor/src/widgets/numeric-input-editor.tsx 18.51% <0.00%> (-55.01%) ⬇️

... and 144 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c8233...49ea2a2. Read the comment docs.

@anakaren-rojas anakaren-rojas deleted the LEMS-1969-numeric-input-widget branch August 7, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants