Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunKit example: simplify output #244

Merged
merged 1 commit into from
Jan 31, 2018
Merged

RunKit example: simplify output #244

merged 1 commit into from
Jan 31, 2018

Conversation

pouwerkerk
Copy link
Contributor

@pouwerkerk pouwerkerk commented Jun 6, 2017

Collapse console.logs via a template literal so that the HTML with CSS is rendered in the RunKit result. RunKit behaves like a REPL so the last value is returned.

The existing RunKit example is great, so this just takes it slightly further so you can see how your browser would render the styles that Aphrodite generates.

You can see it in action here: https://runkit.com/pieter/aphrodite-runkit-example

Before

screen shot 2017-06-06 at 11 34 07 am

After

screen shot 2017-06-06 at 11 34 47 am

@khanbot
Copy link

khanbot commented Jun 6, 2017

Hey @pouwerkerk,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@pouwerkerk
Copy link
Contributor Author

[clabot:check]

@khanbot
Copy link

khanbot commented Jun 6, 2017

CLA signature looks good 👍

@lencioni
Copy link
Collaborator

This looks great to me. Thanks so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants