Bumping actions/gerald-pr to point to newer version of Khan/gerald #91
Conversation
🦋 Changeset detectedLatest commit: cacc3f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -25,7 +25,7 @@ runs: | |||
| ref: '${{ github.head_ref }}' | |||
| if: ${{ github.event.pull_request.draft == false }} | |||
| - name: Run Gerald | |||
| uses: Khan/gerald@v4.0 | |||
| uses: Khan/gerald@v4.1 | |||
There was a problem hiding this comment.
It may be better to just change this to v4 so that minor updates will get rolled out automatically.
There was a problem hiding this comment.
ooooh... I didn't know it can do that! That's interesting... I would have thought that anything after the @ was just an opaque git ref. What part of the system understands semantic versioning embedded in git tags?
There was a problem hiding this comment.
Ah - you know what, I take it back! So this only works for things published in this repo. Gerald isn't set up to do this yet. We have to hardcode the version here...
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Summary:
See this PR with a bug-fix regarding GitHub teams not getting added when author is a member of that team, and the author adds comments. Point this to that, once it's landed and tagged.
I also updated the README with instructions (mostly for myself, because I forgot what I did last time) on how to test PRs in this repo before landing (and publishing).
Issue: XXX-XXXX
Test plan: