Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the keeper-related github actions. #69

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove the keeper-related github actions. #69

merged 1 commit into from
Aug 29, 2023

Conversation

csilvers
Copy link
Member

Summary:

We're moving to using GSM for secrets management, at least for secrets
used in code. So github actions no longer need to be able to access
keeper.

Issue: https://khanacademy.atlassian.net/browse/INFRA-9448

Test plan:

None

We're moving to using GSM for secrets management, at least for secrets
used in code.  So github actions no longer need to be able to access
keeper.

Issue: https://khanacademy.atlassian.net/browse/INFRA-9448

Test plan:
None
@csilvers csilvers self-assigned this Aug 29, 2023
Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for cleaning this up!

@csilvers csilvers merged commit 7b1700e into main Aug 29, 2023
2 checks passed
@csilvers csilvers deleted the keeper-to-gsm branch August 29, 2023 20:07
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: d8cc966

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants