Fix: RA GUI layout (CSS align, SDA bug, Search improv) #551

dcarella · 2024-03-22T00:36:34Z

Changes > Make New Request (CSS align):

CSS horizontal align for 'Make New Request' page (like PR Improve: RA GUI Make New Request page CSS #512): for Token, Name Constraint Attributes, Other Certificate Data, and Other Data
Bug: when only "Name Constraints, Excluded" is checked without "Name Constraints, Permitted", the title "Name Constraint Attributes" is not displayed
Better CSS usage: modify HTML source (with adding style, and div) is better than modify CSS style. So I revert a part of my own CSS contribution (PR Improve: RA GUI Make New Request page CSS #512)
now the CSS is more clear, with less default override, and more readability. So, now it's easier to override 'ra.css'
H3 in bold is really better, and more readable. I just removed the override from the CSS 'w_e_style.css' (and keep the default bold feature from 'ra.css')
when I had added the tags '<h:panelGroup>...<h:panelGroup/>', I didn't indent the content for better review of the code
QA: don't hesitate to test with all Key-pair generation types (By the CA, Provided by user, and Postpone).

Changes > View/Edit End Entity (SDA bug):

in View End Entity: Subject Directory Attributes (SDA) display is broken because the previous display (i.e. SSH options) is bugged
in Edit End Entity: Subject Directory Attributes (SDA) display is broken because the CSS rules doesn't match, because there is an additional 'span' tag

Changes > Edit End Entity (Select list fix, CSS align):

in Edit End Entity: all Select lists have a fixed width which is too narrow (width forced to 'auto' is better for readability)
enlarge all text inputs (like PR Improve: RA GUI Make New Request page CSS #512)
align textarea inputs

Changes > Search for Certificates/End Entities (improvement):

fix some regressions from "Edit End Entity" (Select lists)
in Search for Certificates: the display of date options are now better
in Search for End Entities: the display of date options are now better

…ault action <h:commandButton> gets rendered as <input type=submit>. Pressing the Enter key in an input field on an form with multiple submit buttons is equivalent to clicking the first one. Up to now, the default action of the Edit End Entity form was the dangerous operation "Revoke certificates and delete end entity." It is probably more likely that the user intended to save changes instead, which is the action that is now the default (executed when pressing Enter).

Edit End Entity: reorder buttons, so Revoke And Delete is not the default action

Updated Security policy, added Issue templates

…ix_CMP_sorting

Fix cmp header sender field sorting

L10n: Admin GUI English fix (from version 8.2.0)

…te/8.2.0 L10n: Admin GUI French update (based on 8.2.0) Fully translated

…8.2.0 L10n: Admin GUI French fix (typo)

…xes/8.2.0 L10n: RA GUI Missing keys and fixes (ICAO, OAuth, etc.)

…page-css/8.2.0' into improve/ra-gui-make-new-request-page-css/8.2.0

Fix merge DNs with SANs

change sql syntax from ALTER TABLE ApprovalData MODIFY subjectDn VARCHAR(400); for mysql to ALTER TABLE ApprovalData ALTER COLUMN subjectDn VARCHAR(400); for mssql in 790_7100-upgrade-mssql2000.sql

…-page-css/8.2.0 Improve: RA GUI Make New Request page CSS

…-dn-attributes/8.2.0 Improve: RA GUI Make New Request: DN attributes, and SAN labels

… if an exception occurs

The extra testcase to check CA renewal with key algorithm change and a change to Subject DN.

change sql syntax from ALTER TABLE sometable MODIFY somecolumn sometype; for mysql to ALTER TABLE sometable ALTER COLUMN somecolumn sometype; for mssql in 650_660-upgrade-mssql2000.sql

…ql-upgrade Fix: fix sql syntax error in sql upgrade file for 790_7100

…hen-Key-algorithm-being-changed Fix to issue Link Certificate using previous Signature Algorithm

primetomas · 2024-04-08T14:40:31Z

I will postpone this unti 8.3 is out because there are other changes to 8.3, which is feature freeze soon, and UI changes need a lot of testing on different screen sizes and such.

dcarella · 2024-04-08T20:05:40Z

Alright. I understand.
I had tested with different screen sizes, by resizing my browser window, and with Firefox and Chromium. But it is not a real QA as your team (or you) do. So, later if you discover a problem or a bug, don't hesitate to come back to me about it

Amin Khorsandi and others added 30 commits December 5, 2023 15:43

ECA-11991: Exception class could be CE.

b07e2eb

ECA-11991: Add missing interface impl for CE.

d9aff13

NoTicket: Setting version 8.2.0.1

39b6c93

Merge pull request #433 from uedvt359/fix430

e6b748f

Edit End Entity: reorder buttons, so Revoke And Delete is not the default action

Create bug-report.md

78d21d7

Add files via upload

56bb7c7

Update config.yml

cb85748

Update SECURITY.md

8fd7809

Create bug-report.md

f80412f

Delete .github /ISSUE_TEMPLATE directory

c6b9b78

Add files via upload

0d9e083

Update config.yml

219425e

Update config.yml

46d2a72

Merge pull request #444 from KarolinHem/main

7495765

Updated Security policy, added Issue templates

fix: sets sender acc. RFC9483

5bc3d42

Merge branch 'Keyfactor:main' into Fix_CMP_sorting

605fab0

fix: minor adjustments

f4a5d87

Merge branch 'Fix_CMP_sorting' of github.com:RufusJWB/ejbca-ce into F…

b582f38

…ix_CMP_sorting

Merge pull request #447 from RufusJWB/Fix_CMP_sorting

45819d5

Fix cmp header sender field sorting

Noticket: Message Use entity CN not localized

cbede3c

Noticket: L10n, Better MSAE SPN format help

4c38bfa

Noticket: Add back favicon to Add End-Entity page

25f9e0a

Noticket: Admin GUI French full update

f5a76e6

Noticket: Admin GUI English fix (from 8.2.0)

76ed622

Noticket: Admin GUI English fix (XmppAddr, Matter)

78bfaad

Merge pull request #461 from dcarella/l10n/admin-gui-english-fix/8.2.0

7417071

L10n: Admin GUI English fix (from version 8.2.0)

Merge pull request #460 from dcarella/l10n/admin-gui-french-full-upda…

0966b42

…te/8.2.0 L10n: Admin GUI French update (based on 8.2.0) Fully translated

Noticket: RA GUI English fix (Matter, UID, Subject DN, SAN, EKU)

a6f1c3a

Noticket: RA GUI English fix (Matter, UID, Subject DN, SAN, EKU)

c3ebf92

primetomas and others added 25 commits February 19, 2024 09:42

Merge pull request #490 from dcarella/l10n/admin-gui-french-fix-typo/…

2c0e2a6

…8.2.0 L10n: Admin GUI French fix (typo)

Merge pull request #491 from dcarella/l10n/ra-gui-missing-keys-and-fi…

b722858

…xes/8.2.0 L10n: RA GUI Missing keys and fixes (ICAO, OAuth, etc.)

Noticket: Improve RA GUI Make New Request page (CSS)

1bc6a36

Noticket: Improve RA GUI Make New Request page (CSS)

83c64a0

Merge remote-tracking branch 'origin/improve/ra-gui-make-new-request-…

944df16

…page-css/8.2.0' into improve/ra-gui-make-new-request-page-css/8.2.0

Noticket: Improve RA GUI Make New Request DN attributes

fadc53a

Merge pull request #499 from Stueypoo/FixMergeDNsWithSANs

06edd61

Fix merge DNs with SANs

fix sql syntax error in sql upgrade file for 790_7100

94b82fb

change sql syntax from ALTER TABLE ApprovalData MODIFY subjectDn VARCHAR(400); for mysql to ALTER TABLE ApprovalData ALTER COLUMN subjectDn VARCHAR(400); for mssql in 790_7100-upgrade-mssql2000.sql

Merge pull request #512 from dcarella/improve/ra-gui-make-new-request…

1b876a1

…-page-css/8.2.0 Improve: RA GUI Make New Request page CSS

Merge pull request #514 from dcarella/improve/ra-gui-make-new-request…

3a62dca

…-dn-attributes/8.2.0 Improve: RA GUI Make New Request: DN attributes, and SAN labels

Updates reccommended by KeyFactor

2f59ac8

Replacing hardcoded "TEST" with the method 'getTestCAName()'

c334c7c

Add try/finally to ensure any SignatureAlgorithm changes are put back…

41ff941

… if an exception occurs

Added extra testcase and additional assertions for improved testing

e7e7fc4

The extra testcase to check CA renewal with key algorithm change and a change to Subject DN.

minor clean ups to tests

e742c56

Use cloned certificate profile to force the old algorithm

dd435a3

simplify because we always must use the old signature algorithm

5f77209

Update 650_660-upgrade-mssql2000.sql

44d4814

change sql syntax from ALTER TABLE sometable MODIFY somecolumn sometype; for mysql to ALTER TABLE sometable ALTER COLUMN somecolumn sometype; for mssql in 650_660-upgrade-mssql2000.sql

Merge pull request #517 from wyverm/fix-sql-upgrade-syntax-error-in-s…

634c277

…ql-upgrade Fix: fix sql syntax error in sql upgrade file for 790_7100

Merge pull request #500 from Stueypoo/Fix-for-CSCA-Link-Certificate-w…

dac8b32

…hen-Key-algorithm-being-changed Fix to issue Link Certificate using previous Signature Algorithm

Noticket: RA GUI layout (Make New Request)

c8f4c25

Noticket: RA GUI layout (fix: Make New Request)

55b7652

Noticket: RA GUI layout (SDA bug in View/Edit End Entity)

6990dc5

Noticket: RA GUI layout (Edit End Entity)

4641637

Noticket: RA GUI layout (Search for Certificates/End Entities)

31177d5

hesunmark force-pushed the main branch from 641901b to fb6acdc Compare June 13, 2024 14:18

dcarella closed this by deleting the head repository Jul 1, 2024

dcarella mentioned this pull request Jul 8, 2024

Fix: RA GUI layout (CSS align, SDA bug, Search improv) #624

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: RA GUI layout (CSS align, SDA bug, Search improv) #551

Fix: RA GUI layout (CSS align, SDA bug, Search improv) #551

dcarella commented Mar 22, 2024

primetomas commented Apr 8, 2024

dcarella commented Apr 8, 2024

Fix: RA GUI layout (CSS align, SDA bug, Search improv) #551

Fix: RA GUI layout (CSS align, SDA bug, Search improv) #551

Conversation

dcarella commented Mar 22, 2024

primetomas commented Apr 8, 2024

dcarella commented Apr 8, 2024