Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark mode adaptive for #29 #30

Merged
merged 4 commits into from
Oct 4, 2021
Merged

dark mode adaptive for #29 #30

merged 4 commits into from
Oct 4, 2021

Conversation

doubleZ0108
Copy link
Contributor

#29 修复黑色模式适配的两个小问题

  1. 一些quick open的小框（🌰e.g. 插入代码框弹出的语言候选框）
  2. 插入图片之后弹出的小框

RalXYZ and others added 3 commits September 1, 2021 20:31
@RalXYZ
Merge pull request #25 from Keldos-Li/dev/sass
a2144a2 
补充文档，用 Makefile 替代 make.sh，改进文件结构
@RalXYZ
Merge pull request #26 from Keldos-Li/dev/sass
1176060 
在安装包中添加安装教程、论文封面模板和一些示例文档
@doubleZ0108
dark mode adaptive for 2 issues
5f0a6ea
@RalXYZ RalXYZ changed the base branch from main to dev/sass October 4, 2021 06:30
RalXYZ
RalXYZ reviewed Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@RalXYZ RalXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您知道除了语言候选框之外， Typora 还有什么其他 quick open 框吗？
主要是，我在想 #typora-quick-open input 这个选择器定义了哪个组件的样式。看起来是与具备文字输入功能的 quick open 框有关？

@doubleZ0108
Copy link
Contributor Author

下载本主题之后我写了3个小项目的文档，按照我的使用习惯暂时没发现其他没适配的的地方

个人看下来觉得弹出框主要有三种

  1. 主动右键（应该是直接引用的base）
  2. 插入代码后按照逻辑会弹出的框
  3. 插入图片按照逻辑弹出的框（不知道为什么没跟上一个合并，猜想可能是这是一个有多级的菜单，估计代码重写了）

我昨天简单看了Typora官网关于自定义样式的说明，其中有关自带的一些dialog没有很明确的定义

不过我看咱们的代码和官方的github、night相比有相当一部分的精炼，主要集中在这些交互的细节处

@RalXYZ
Copy link
Collaborator

RalXYZ commented Oct 4, 2021

我昨天简单看了Typora官网关于自定义样式的说明，其中有关自带的一些dialog没有很明确的定义

感谢。我未来会仔细研究一下。

@RalXYZ RalXYZ added the 🛠 enhancement PR: new feature or request label Oct 4, 2021
RalXYZ
RalXYZ approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@RalXYZ RalXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我刚刚进行了一点颜色上的修改，我认为这样会看起来更和谐一些：
image

@RalXYZ RalXYZ linked an issue Oct 4, 2021 that may be closed by this pull request
黑色模式适配的两个小问题 #29
Closed
@RalXYZ RalXYZ requested a review from Keldos-Li October 4, 2021 07:03
Keldos-Li
Keldos-Li approved these changes Oct 4, 2021
View reviewed changes
Copy link
Owner

@Keldos-Li Keldos-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

太好啦😘

@doubleZ0108
Copy link
Contributor Author

嗯嗯 好棒呀👍🏻

我刚刚进行了一点颜色上的修改，我认为这样会看起来更和谐一些：
image

@RalXYZ RalXYZ merged commit 1f2e116 into Keldos-Li:dev/sass Oct 4, 2021
@RalXYZ RalXYZ mentioned this pull request Oct 4, 2021
Closed
@RalXYZ
Copy link
Collaborator

RalXYZ commented Oct 4, 2021

@doubleZ0108
我在 #31 提出了一些其他与暗色适配相关的问题。如果您对此感兴趣，我们欢迎您继续做出贡献。

pull bot pushed a commit to Yourrrrlove/typora-latex-theme that referenced this pull request Apr 15, 2022
@RalXYZ
Merge pull request Keldos-Li#30 from doubleZ0108/dev/dark
9c3709f 
fix Keldos-Li#29 

Former-commit-id: 1f2e116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalXYZ RalXYZ RalXYZ approved these changes

@Keldos-Li Keldos-Li Keldos-Li approved these changes

Assignees
No one assigned
Labels
🛠 enhancement PR: new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

黑色模式适配的两个小问题
3 participants
@doubleZ0108 @RalXYZ @Keldos-Li