Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing requirements to use pipenv only #59

Merged
merged 4 commits into from
Oct 4, 2018

Conversation

elfosardo
Copy link
Contributor

as discussed in issue #55 we should remove requirements from the picture and use pipenv only
the Pipfile and Pipfile.lock files are already configured so with this PR we're just removing the requirements structure

@liadmagen
Copy link
Member

I think it needs the requests package. using:
pipenv install requests
will add it to the pipfile, and it will pass the integration tests

@elfosardo
Copy link
Contributor Author

@liadmagen thanks for the suggestion, I will give it a try

@elfosardo
Copy link
Contributor Author

@liadmagen I can see requests already in the Pipfile under packages section
looking back at the integration logs it seems like it's missing the responses package instead

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          13       13           
  Lines         219      219           
  Branches       23       23           
=======================================
  Hits          183      183           
  Misses         32       32           
  Partials        4        4

Copy link
Member

@liadmagen liadmagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👍

@liadmagen liadmagen merged commit 7f829b6 into Keep-Current:master Oct 4, 2018
@elfosardo elfosardo deleted the remove_requirements.txt branch October 4, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants