Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the initialization to run the app #57

Merged
merged 17 commits into from
Sep 24, 2018
Merged

Conversation

liadmagen
Copy link
Member

@liadmagen liadmagen commented Sep 23, 2018

Proposed changes

This is a fix for the gunicron initialization of the app. I hope now the app will load properly in production.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • [X ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #57 into master will increase coverage by 18.49%.
The diff coverage is 70%.

@@             Coverage Diff             @@
##           master      #57       +/-   ##
===========================================
+ Coverage   65.06%   83.56%   +18.49%     
===========================================
  Files          13       13               
  Lines         229      219       -10     
  Branches       27       23        -4     
===========================================
+ Hits          149      183       +34     
+ Misses         79       32       -47     
- Partials        1        4        +3

@liadmagen liadmagen merged commit cf2d1c3 into master Sep 24, 2018
@liadmagen liadmagen deleted the bugfix/56-app-crashes-on branch September 24, 2018 13:44
@liadmagen liadmagen restored the bugfix/56-app-crashes-on branch September 24, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant