Skip to content

Commit

Permalink
for codacy - replaced more assert statements with raise AssertionError
Browse files Browse the repository at this point in the history
  • Loading branch information
liadmagen committed Sep 23, 2018
1 parent 164fe8c commit 7209717
Showing 1 changed file with 18 additions and 14 deletions.
32 changes: 18 additions & 14 deletions tests/entities/test_arxiv_document.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ def test_arxiv_doc_model_init():
publish_date=test_publish_date,
pdf_url=test_pdf_url,
)
assert arxiv_doc.doc_id == code
assert arxiv_doc.url == test_url
assert arxiv_doc.title == test_title
assert arxiv_doc.abstract == test_abstract
assert arxiv_doc.authors == test_authors
assert arxiv_doc.publish_date == test_publish_date
assert arxiv_doc.pdf_url == test_pdf_url
assert_equal(arxiv_doc.doc_id, code)
assert_equal(arxiv_doc.url, test_url)
assert_equal(arxiv_doc.title, test_title)
assert_equal(arxiv_doc.abstract, test_abstract)
assert_equal(arxiv_doc.authors, test_authors)
assert_equal(arxiv_doc.publish_date, test_publish_date)
assert_equal(arxiv_doc.pdf_url, test_pdf_url)


def test_arxiv_doc_model_from_dict():
Expand All @@ -52,10 +52,14 @@ def test_arxiv_doc_model_from_dict():
"links": [{"title": "pdf", "href": "https://arxiv.org/pdf/1801.06605"}],
}
)
assert arxiv_doc.doc_id == code
assert arxiv_doc.url == test_url
assert arxiv_doc.title == test_title
assert arxiv_doc.abstract == test_abstract
assert arxiv_doc.authors == test_authors
assert arxiv_doc.publish_date == test_publish_date
assert arxiv_doc.pdf_url == test_pdf_url
assert_equal(arxiv_doc.doc_id, code)
assert_equal(arxiv_doc.url, test_url)
assert_equal(arxiv_doc.title, test_title)
assert_equal(arxiv_doc.abstract, test_abstract)
assert_equal(arxiv_doc.authors, test_authors)
assert_equal(arxiv_doc.publish_date, test_publish_date)
assert_equal(arxiv_doc.pdf_url, test_pdf_url)

def assert_equal(arg1, arg2):
if arg1 != arg2:
raise AssertionError("Assert equal failed - values are not equal")

0 comments on commit 7209717

Please sign in to comment.