Skip to content

Commit

Permalink
added a basic test to the arxiv_repo
Browse files Browse the repository at this point in the history
  • Loading branch information
liadmagen committed Sep 23, 2018
1 parent 897b955 commit 47c6380
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 1 deletion.
65 changes: 65 additions & 0 deletions tests/use_case/test_arxiv_repo.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
"""Tests the arxiv repository
"""

import pytest

from webminer.entities.arxiv_document import ArxivDocument
from webminer.use_cases.request_arxiv import arxiv_repo as a_repo

arxiv_doc_1 = ArxivDocument(
doc_id="url_1",
url="url_1",
title="title_1",
abstract="abstract_1",
authors=["author1", "author2"],
publish_date="publish_date_1",
pdf_url="pfg_url1",
)

arxiv_doc_2 = ArxivDocument(
doc_id="url_2",
url="url_2",
title="title_2",
abstract="abstract_2",
authors=["author2", "author2"],
publish_date="publish_date_2",
pdf_url="pfg_url2",
)

arxiv_doc_3 = ArxivDocument(
doc_id="url_3",
url="url_3",
title="title_3",
abstract="abstract_3",
authors=["author3", "author2"],
publish_date="publish_date_3",
pdf_url="pfg_url3",
)

arxiv_doc_4 = ArxivDocument(
doc_id="url_4",
url="url_4",
title="title_4",
abstract="abstract_4",
authors=["author4", "author2"],
publish_date="publish_date_4",
pdf_url="pfg_url4",
)

@pytest.fixture
def domain_arxivdocs():
"""Creates a fixture for the returned objects
"""
return [arxiv_doc_1, arxiv_doc_2, arxiv_doc_3, arxiv_doc_4]


def _check_results(domain_models_list, data_list):
assert len(domain_models_list) == len(data_list)
assert all([isinstance(dm, DomainModel) for dm in domain_models_list])
assert set([dm.doc_id for dm in domain_models_list]) == \
set([d['doc_id'] for d in data_list])

def test_repository_list_without_parameters(domain_arxivdocs):
repo = a_repo.ArxivRepo(domain_arxivdocs)

assert repo.list() == domain_arxivdocs
4 changes: 3 additions & 1 deletion webminer/use_cases/request_arxiv/arxiv_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ def list(self, filters=None):
"""

if not filters:
return self.fetch_papers()
return self._entries

self._entries = self.fetch_papers()

result = []
result.extend(self._entries)
Expand Down

0 comments on commit 47c6380

Please sign in to comment.