Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link shared metis lib against GKlib #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catap
Copy link

@catap catap commented Dec 1, 2022

No description provided.

@karypis
Copy link
Contributor

karypis commented Dec 4, 2022

Will that remove the need for a 3P library to need to link with both Metis and GKlib?

@catap
Copy link
Author

catap commented Dec 5, 2022

@karypis nope, it doesn't, see: KarypisLab/ParMETIS#23.

I suggest to make a cmake package to make things easy.

This patch is used to allow compiling a dynamic library. Without it, it fails as:

Undefined symbols for architecture x86_64:
  "_gk_CPUSeconds", referenced from:
      _libmetis__CoarsenGraph in coarsen.c.o
      _libmetis__Match_RM in coarsen.c.o
      _libmetis__Match_SHEM in coarsen.c.o
      _CoarsenGraphNlevels in coarsen.c.o
      _libmetis__CreateCoarseGraph in coarsen.c.o
      _libmetis__Match_2HopAny in coarsen.c.o
      _libmetis__Match_2HopAll in coarsen.c.o
      ...
  "_gk_cur_jbufs", referenced from:
      _METIS_PartGraphKway in kmetis.c.o
      _METIS_MeshToDual in mesh.c.o
      _METIS_MeshToNodal in mesh.c.o
      _METIS_PartMeshNodal in meshpart.c.o
      _METIS_PartMeshDual in meshpart.c.o
      _METIS_NodeND in ometis.c.o
      _METIS_PartGraphRecursive in pmetis.c.o
      ...
...

@catap
Copy link
Author

catap commented Apr 24, 2023

@karypis any thoughts about this one? This is the only patch that is required by MacPorts :)

I'd love to have it merged and remove all patches.

@LecrisUT
Copy link

#79 brings in a more modern approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants