Introduce kotlin coroutines flow #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonilopezmr
reviewed
Sep 18, 2019
| view.showLoader() | ||
| getPhotosJob = launchInMain { | ||
| try { | ||
| logInfo(TAG, "Start getting photos") |
There was a problem hiding this comment.
Do we lose the logs? I'd prefer to keep those logs to understand in common module how is going the code in both platforms (android or iOS)
| fun onCreate() = launchInMain { | ||
| view.render(View.State.Loading) | ||
| getAllPhotos() | ||
| .flowOnBackground() |
|
|
||
| suspend fun get(): Flow<Photos> = | ||
| timer(repeatEvery = updateInterval) | ||
| .map { photosApiClient.getPhotos() } |
There was a problem hiding this comment.
This is because you emit Unit but after that, you map it to the Photos you get from .getPhotos(), right?
There was a problem hiding this comment.
Yes, the timer does not emit anything of value, just happens to do it in a convenient interval :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
🎩 What is the goal?
To introduce Flow into the project. The approach is not the best one but we now know this is possible.
📝 How is it being implemented?
rendermethod and passing a sealed class. This is just an idea for the future I've been having for a while, doing so can make it way easier to test presenter+view interaction with the help of snapshot testing, it's not really needed for this project though.timerflow that returns aUnitvalue with a configurable interval.PhotosFlowinstead of doing it with the API directly.Delayinterface to the iOS Dispatcher. This let us call thedelayfunction that we are using in thetimerflow. The previous implementation would just stop whenever it found a delay, making the app useless in iOS. The new code has been extracted from here.💥 How can it be tested?
Automatically!