Account for missing snapshots in Track retrieval #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kambrian
requested changes
Jun 1, 2021
| # moved around | ||
| if not os.path.isdir(self.rootdir): | ||
| self.rootdir = self.rootdir.replace( | ||
| '/gpfs/data/jvbq85', '/cosma/home/durham/jvbq85/data') |
There was a problem hiding this comment.
should be kept private.
a better fix is to change path argument to paramfile, so that the user can supply an updated paramfile.
| with self.Open(-1) as f: | ||
| self.ParticleMass=f['/Cosmology/ParticleMass'][0] | ||
| except: | ||
| #print("Info: fail to get ParticleMass.") |
| self._valid_snapshots = np.array( | ||
| [os.path.isfile(self.GetFileName(i)) | ||
| for i in range(self.MaxSnap+1)]) | ||
| return self._valid_snapshots |
There was a problem hiding this comment.
I assume this is only to account for a different MinSnap? if there are missing snaps in between, then some records like SnapshotIndexOfLastIsolation etc. will break. Then it will be friendly to print some warning message about the missing ones.
| if hasattr(snapbirth, '__iter__'): | ||
| snapbirth = snapbirth[0] | ||
| snaps = np.arange(snapbirth, self.MaxSnap+1, dtype=int) | ||
| to = time() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace pylab.find (no longer available)