Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pins for jupyter packages. #989

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Remove pins for jupyter packages. #989

merged 1 commit into from
Apr 9, 2021

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Apr 7, 2021

  • Use simply the version from our DLVM base image.
  • Removed the meta-package jupyter. It references packages already
    installed.

This ensures we have the jupyter packages in sync with DLVM and ensures
compatibility with the Cloud AI Notebook environment.

- Use simply the version from our DLVM base image.
- Removed the meta-package `jupyter`. It references packages already
installed.

This ensures we have the jupyter packages in sync with DLVM and ensures
compatibility with the Cloud AI Notebook environment.
@rosbo rosbo requested a review from djherbis April 9, 2021 16:28
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll def. want to test this carefully before rolling out but LGTM, thanks!

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@rosbo rosbo merged commit 752a79c into master Apr 9, 2021
@rosbo rosbo deleted the remove-jupyter-pins branch April 9, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants