Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall google-cloud-bigquery-storage library. #977

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Mar 25, 2021

This library is part of our base image (deeplearning-platform-release)
but not other libraries depend on it.

Removing this library ensures the bigquery library fall backs on using
regular BQ queries to fetch data.

The BigQuery storage APIs are not supported by our data proxy and we
don't monkey patch this client.

This change simply revert to the behavior we had with BQ 1.x libraries.

http:https://b/183041606

This library is part of our base image (deeplearning-platform-release)
but not other libraries depend on it.

Removing this library ensures the bigquery library fall backs on using
regular BQ queries to fetch data.

The BigQuery storage APIs are not supported by our data proxy and we
don't monkey patch this client.

This change simply revert to the behavior we had with BQ 1.x libraries.

http:https://b/183041606
@rosbo rosbo requested a review from bovard March 25, 2021 19:02
Copy link
Member

@bovard bovard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosbo rosbo merged commit 451c665 into master Mar 25, 2021
@rosbo rosbo deleted the disable-bigquery-storage branch March 25, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants