GCP ML services integration. #925
Conversation
Video intelligence GCP integrations.
kornelregius
changed the title
patches/kaggle_gcp.py
Outdated
| return translate_v3 | ||
| from kaggle_secrets import GcpTarget | ||
| kernel_credentials = KaggleKernelCredentials(target=GcpTarget.TRANSLATION) | ||
| monkeypatch_client(translate_v3.TranslationServiceClient,kernel_credentials) |
There was a problem hiding this comment.
nit: Whitespace after a comma http:https://go/pystyle#whitespace
There was a problem hiding this comment.
Fixed in ef87f07
patches/kaggle_gcp.py
Outdated
|
|
||
| from kaggle_secrets import GcpTarget | ||
| kernel_credentials = KaggleKernelCredentials(target=GcpTarget.NATURAL_LANGUAGE) | ||
| monkeypatch_client(language.LanguageServiceClient,kernel_credentials) |
There was a problem hiding this comment.
nit: Whitespace after a comma http:https://go/pystyle#whitespace
Same for following line
patches/kaggle_gcp.py
Outdated
|
|
||
| from kaggle_secrets import GcpTarget | ||
| kernel_credentials = KaggleKernelCredentials(target=GcpTarget.VISION) | ||
| monkeypatch_client(vision.ImageAnnotatorClient,kernel_credentials) |
There was a problem hiding this comment.
nit: Whitespace after a comma http:https://go/pystyle#whitespace
Same next line
There was a problem hiding this comment.
Fixed in ef87f07
patches/sitecustomize.py
Outdated
| 'google.cloud.videointelligence_v1', | ||
| 'google.cloud.vision', | ||
| 'google.cloud.vision_v1', | ||
| ] |
There was a problem hiding this comment.
nit: I think you have to align the ] with _MODULES, or put it after / on the same line as the last element
There was a problem hiding this comment.
Fixed in ef87f07
|
LGTM. The tests are failing for an orthogonal reason. I will fix master today and let you know when you can rebase your branch with the latest changes. After that, if all the build for your branch is green, you will be able to merge this. Thank you |
|
@kornelregius I merged #929 which fixes the |
Add GCP integrations with the latest client major versions of
ticket: b/175030896
Do not merge until corresponding GCP integration controller version released!