-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapidsai (cudf and cuml) #595
Conversation
To run jupyterlabs in the container and have access to the gpu in the notebooks I had to use the following docker run command:
|
The CI tests fail with:
I guess because the import at the beginning of the test files are not available for CPU tests. |
Moved GPU specific imports into the GPU tests themselves to resolve import failures on cpu container. We also cannot incorporate newer version of rapids until pandas is updated >=0.24.2, <0.25. |
tests/test_cuml.py
Outdated
import unittest | ||
|
||
from sklearn import datasets | ||
from cuml import LinearRegression as cuLinearRegression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may have forgotten to remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your right I will update that.
Is this blocking this PR? |
No rapids version 0.8 works fine. However, the most recent released version is 0.9 with 0.10 coming soon. Those versions of rapids will be blocked by that pandas requirement (>=0.24.2, <0.25). |
Thank you for your contribution! |
Unfortunately, we are moving to tensorflow 2 and it looks like the library is not supported. https://github.com/Kaggle/docker-python/pull/573/files |
Revert "Merge pull request #595 from jperez999/master"
No description provided.