Move JWE to request body instead of header. #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimota
commented
Feb 21, 2019
| @@ -2,7 +2,6 @@ FROM gcr.io/kaggle-images/python-tensorflow-whl:1.12.0-py36 as tensorflow_whl | |||
| FROM continuumio/anaconda3:5.2.0 | |||
|
|
|||
| ADD clean-layer.sh /tmp/clean-layer.sh | |||
| ADD patches/ /tmp/patches/ | |||
There was a problem hiding this comment.
I removed this since it was causing a lot of layers to be rebuilt if patches was ever changed, and I couldn't see any use of /tmp/patches - but please let me know if there's something I'm overlooking!
rosbo
approved these changes
Feb 21, 2019
| @@ -2,7 +2,6 @@ FROM gcr.io/kaggle-images/python-tensorflow-whl:1.12.0-py36 as tensorflow_whl | |||
| FROM continuumio/anaconda3:5.2.0 | |||
|
|
|||
| ADD clean-layer.sh /tmp/clean-layer.sh | |||
| ADD patches/ /tmp/patches/ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving the JWT to the body from the header, as the current Mediator framework in the Web Tier doesn't pass headers to the Service/Controllers.