Add support for jieba #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I resolved the conflict on your PR and removed the gensim addition because it is now already being added earlier in the Dockerfile. |
|
@Gyczero could you add unit tests for this package to prevent regression. Just pick one simple canonical usage of this package. Here is an example: https://github.com/Kaggle/docker-python/blob/master/tests/test_fastai.py |
Closed
|
@rosbo I added unit tests for jieba and thanks for adding gensim which is very helpful for NLP! |
rosbo
requested changes
Sep 27, 2018
rosbo
reviewed
Sep 27, 2018
tests/test_jieba.py
Outdated
| class TestJieba(unittest.TestCase): | ||
| def test_text_split(self): | ||
| sentence = "我爱北京天安门" | ||
| seg_list = jieba.cut(sentence) |
There was a problem hiding this comment.
can you add an assertion for this test please.
Maybe self.assertEqual(X, len(seg_list)) where X is the number of segments.
There was a problem hiding this comment.
Sure, I added an assertion.
rosbo
approved these changes
Oct 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gensim is a famous toolkit for topic modeling
jieba is a famous Chinese toolkit for text segmentation