Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datasets #1379

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix datasets #1379

merged 3 commits into from
Apr 2, 2024

Conversation

calderjo
Copy link
Contributor

@calderjo calderjo commented Apr 2, 2024

unpin datasets, looks like an attempt was made to do this in past but failed due to tfjs

but we don't install that package anymore. so let's unpin it since breaking due to package conflicts
moved s3fs to get a compatible version with fsspec. directly installed gcsfs, this is indirectly installed by another package but complains about fsspec version. installing directly seems to do the trick.

manually tested load_dataset function, works!

#1343
b/232247930

@calderjo calderjo requested a review from djherbis April 2, 2024 16:49
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could we maybe add the failed code to the test?

from datasets import Dataset

@calderjo
Copy link
Contributor Author

calderjo commented Apr 2, 2024

Thanks!

Could we maybe add the failed code to the test?

from datasets import Dataset

your wish is my command

@calderjo calderjo requested a review from djherbis April 2, 2024 17:38
@calderjo calderjo mentioned this pull request Apr 2, 2024
@calderjo calderjo merged commit 9f45493 into main Apr 2, 2024
4 checks passed
@calderjo calderjo deleted the resolve-dataset-issue branch April 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants