Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optree #1376

Merged
merged 1 commit into from
Mar 28, 2024
Merged

add optree #1376

merged 1 commit into from
Mar 28, 2024

Conversation

calderjo
Copy link
Contributor

@calderjo calderjo commented Mar 28, 2024 •
edited
Loading

keras 3.11.something moved from optree to dm-tre. other keras-related packages still need optree

add package, tested locally seems to pass smoke test.

cc: @lucyhe

@calderjo calderjo requested a review from djherbis March 28, 2024 17:47
djherbis
djherbis approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah this is def. a consequence of us installing Keras with --no-deps.
Hopefully we can upgrade the base image soon to fix that.

@calderjo calderjo merged commit ce896ee into main Mar 28, 2024
4 checks passed
@calderjo calderjo deleted the add-optree branch March 28, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djherbis djherbis djherbis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calderjo @djherbis