Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 7zip #1172

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Add support for 7zip #1172

merged 2 commits into from
Jun 28, 2022

Conversation

SohierDane
Copy link
Contributor

No description provided.

@SohierDane SohierDane requested a review from rosbo June 27, 2022 21:53
Dockerfile.tmpl Outdated
@@ -528,6 +528,9 @@ RUN mkdir -p /root/.EasyOCR/model && \
rm /root/.EasyOCR/model/craft_mlt_25k.zip && \
/tmp/clean-layer.sh

# Add 7z support
RUN apt-get install -y p7zip-full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compressed package will be part of that Docker image layer which will make the Docker image size larger make sure to add the following:

RUN apt-get install -y p7zip-full && \
    /tmp/clean-layer.sh

Alternatively (better), you can add it at line to line 62 next to the the unzip package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the install to line 62 as you suggested.

@SohierDane SohierDane merged commit ad95fba into main Jun 28, 2022
@SohierDane SohierDane deleted the add_7z branch June 28, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants