Move TORCH_VERSION ARG below the FROM #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make it available with that build context. The other ARGs are above because they are used in the FROM statement themselves but not the build context of the last image.
djherbis
approved these changes
May 17, 2022
|
|
||
| FROM gcr.io/cloud-tpu-v2-images/libtpu:${LIBTPU_IMAGE_TAG} as libtpu | ||
| FROM gcr.io/kaggle-images/python-tpu-tensorflow-whl:python-${BASE_IMAGE_TAG}-${TENSORFLOW_VERSION} AS tensorflow_whl | ||
| FROM gcr.io/kaggle-images/python:${BASE_IMAGE_TAG} | ||
|
|
||
| ARG TORCH_VERSION |
There was a problem hiding this comment.
Should we add a comment explaining this so no one moves it up in the future?
|
I tested running the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to make it available with that build context.
The other ARGs are above because they are used in the FROM statement themselves but not the build context of the last image.
I also updated the URL for installing
torch_xla. The version of Torch should not include the minor version.