Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest version of nbconvert to fix Jinja issue. #1141

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Mar 28, 2022

The latest version of Jinja changed the import for Markup.

The import was fixed in the latest version of nbconvert: jupyter/nbconvert#1736

We include the version of nbconvert from the DLVM base image which is
released every ~2 weeks. However, the nbconvert fix was released only
6 hours ago.

Temporarily install thel latest version of nbconvert.

Add a test to prevent regression.

http:https://b/227194111

The latest version of Jinja changed the import for `Markup`.

The import was fixed in the latest version of `nbconvert`: jupyter/nbconvert#1736

We include the version of `nbconvert` from the DLVM base image which is
released every ~2 weeks. However, the `nbconvert` fix was released only
6 hours ago.

Temporarily install thel latest version of `nbconvert`.

Add a test to prevent regression.

http:https://b/227194111
@rosbo rosbo requested a review from djherbis March 28, 2022 16:13
@rosbo rosbo merged commit 66a12ac into main Mar 28, 2022
@rosbo rosbo deleted the fix-nbconvert-jinja-error branch March 28, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants