-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand pip install #1075
expand pip install #1075
Conversation
is there a way how to check why the build is failing? |
I'm currently moving our build to a templatized build and will incorporate this idea after I merge #1078 |
@rosbo is there an interest in finishing this one, if yes, I am happy to resolve conflicts and continue... 🐰 |
Looping in @djherbis who is now responsible to manage this docker image / repo. |
@Borda I think this is a good change, though I think the main branch has drifted a decent amount from where this is. |
yes, happy to do it (that was my concern if there is interest in this direction so the work wont land flat 🐿️ ) |
f9fced9
to
fc7b613
Compare
@Borda There is a CI, however it's private so only Kaggle sees the output. We should eventually try to get the build to work on a public CI as well. |
cool, thanks 🐰 |
Thanks for all your hard work @Borda everything passed :) great work! |
Description
this allows pip to resolve eventual version conflicts within particular layers
as it was now, there was no guarantee that the next installed package would break the previous installation (for example, min NumPy version)
Follow-up
I would suggest also doing it in the remaining dockers.
Moreover, reducing duplication may simplify the readability, aka define required packages in extra files and install them within the docker build...
(if agreed, I am happy to make both suggestions 🐰 )