Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand pip install #1075

Merged
merged 7 commits into from
Jan 26, 2023
Merged

expand pip install #1075

merged 7 commits into from
Jan 26, 2023

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 20, 2021

Description

this allows pip to resolve eventual version conflicts within particular layers
as it was now, there was no guarantee that the next installed package would break the previous installation (for example, min NumPy version)

Follow-up

I would suggest also doing it in the remaining dockers.
Moreover, reducing duplication may simplify the readability, aka define required packages in extra files and install them within the docker build...
(if agreed, I am happy to make both suggestions 🐰 )

@Borda
Copy link
Contributor Author

Borda commented Sep 20, 2021

is there a way how to check why the build is failing?
maybe #1077 could help here 🐰

Dockerfile Outdated Show resolved Hide resolved
@rosbo
Copy link
Contributor

rosbo commented Sep 23, 2021

I'm currently moving our build to a templatized build and will incorporate this idea after I merge #1078

Dockerfile Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Sep 23, 2021

I'm currently moving our build to a templatized build and will incorporate this idea after I merge #1078

@rosbo I a not sure why it would not be compatible, the idea is to decouple the packages/version from the Docker structure so it will be lighter and easier to compare differences...

@Borda Borda requested a review from rosbo August 26, 2022 19:20
@rosbo rosbo requested review from djherbis and removed request for rosbo August 26, 2022 19:21
@Borda
Copy link
Contributor Author

Borda commented Jan 8, 2023

@rosbo is there an interest in finishing this one, if yes, I am happy to resolve conflicts and continue... 🐰

@rosbo
Copy link
Contributor

rosbo commented Jan 24, 2023

Looping in @djherbis who is now responsible to manage this docker image / repo.

@djherbis
Copy link
Contributor

@Borda I think this is a good change, though I think the main branch has drifted a decent amount from where this is.
If you can resolve the conflicts, feel free to ping me and I'll review.
I think this is a good step, I think the only concern I might have is if it might slow installation time if it has to do complex version matching but happy to try.

@Borda
Copy link
Contributor Author

Borda commented Jan 25, 2023

If you can resolve the conflicts, feel free to ping me and I'll review.

yes, happy to do it (that was my concern if there is interest in this direction so the work wont land flat 🐿️ )

@Borda Borda requested review from rosbo and removed request for djherbis January 25, 2023 11:26
Dockerfile.tmpl Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Jan 25, 2023

@djherbis just cleaned out the PR - reset to head and add all changes from the ground, so it shall be fine now... just curious is there a CI to verify these changes? as discussed in #1077 and #1078 🐿️

Dockerfile.tmpl Outdated Show resolved Hide resolved
@djherbis
Copy link
Contributor

@Borda There is a CI, however it's private so only Kaggle sees the output.
I'll let you know when/if CI passes.

We should eventually try to get the build to work on a public CI as well.

@Borda
Copy link
Contributor Author

Borda commented Jan 25, 2023

I'll let you know when/if CI passes.

cool, thanks 🐰

@Borda Borda requested review from djherbis and removed request for rosbo January 25, 2023 17:00
Dockerfile.tmpl Outdated Show resolved Hide resolved
@Borda Borda requested a review from rosbo January 26, 2023 09:18
@Borda Borda requested review from djherbis and rosbo and removed request for rosbo and djherbis January 26, 2023 09:18
@djherbis djherbis merged commit eca5485 into Kaggle:main Jan 26, 2023
@djherbis
Copy link
Contributor

Thanks for all your hard work @Borda everything passed :) great work!

@Borda Borda deleted the pip/install-default branch January 26, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants