Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Pydantic v2 Strict mode #3

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Enable Pydantic v2 Strict mode #3

merged 4 commits into from
Oct 17, 2023

Conversation

PaulVanSchayck
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (14fb3e8) 97.93% compared to head (152f167) 97.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   97.93%   97.95%   +0.02%     
==========================================
  Files          10       10              
  Lines         194      196       +2     
==========================================
+ Hits          190      192       +2     
  Misses          4        4              
Flag Coverage Δ
unittests 97.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/edr_pydantic/base_model.py 100.00% <ø> (ø)
src/edr_pydantic/collections.py 100.00% <100.00%> (ø)
src/edr_pydantic/extent.py 100.00% <ø> (ø)
src/edr_pydantic/parameter.py 88.23% <100.00%> (+1.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Roconda Roconda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PaulVanSchayck PaulVanSchayck merged commit 50d8d7f into main Oct 17, 2023
5 checks passed
@PaulVanSchayck PaulVanSchayck deleted the strict-mode branch October 17, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants