Small improvements CRequest #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to reduce de cyclomatic complexity of CRequest (removing nested ifs where possible), also moving some code around to avoid redundancy. Tried to return as soon as possible instead of keeping the algorithm going with conditions that evaluate to false over and over.
Some variable names clarified.
In general, very minor changes (I've kept all the comments even if they are blocks that should go away because I was not sure).
It's extremely difficult and probably future steps should involve putting the different blocks of code into different files, to make it more maintainable.