-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peripheral blocking scope from finishing #378
Comments
Thanks for the issue report! It is a good reminder that this portion of Kable is overdue for a redesign. Short-term: I think providing Long-term: I'd like to remove the reliance on a The nitty gritty details are: Initially |
As identified in #378, `Peripheral` objects eagerly lean on the `CoroutineScope` receiver provided at `Peripheral` creation. This isn't necessary and this is a small step in removing the crutches that were being relied on.
As identified in #378, `Peripheral` objects eagerly lean on the `CoroutineScope` receiver provided at `Peripheral` creation. This isn't necessary and this is a small step in removing the crutches that were being relied on.
As identified in #378, `Peripheral` objects eagerly lean on the `CoroutineScope` receiver provided at `Peripheral` creation. This isn't necessary and this is a small step in removing the crutches that were being relied on.
Bug report
When using
scope.peripheral(...)
it will block scope from finishing.I am developing an Android application and I've tried versions
0.18.0
,0.17.2
,0.16.1
and unreleased version0.18.0-issue-359-1-SNAPSHOT
was crashing when using different contexts.How to reproduce
A coroutine is not finished unless the job is manually canceled.
Even worse when using a different context:
Expected behavior
Either should not block scope and be closed automatically or should provide
peripheral.close()
method for closing the peripheral.The text was updated successfully, but these errors were encountered: