Fixed the bug in GeneralOptions where is wasn't setting the offset and sort parameters #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like a simple copy 'n' paste bug. The code in GeneralOptions.GetParameters is checking against limit.HasValue for limit, offset, and sort. Updated to check offset.HasValue for offset, and sort.HasValue for sort.
JustinBeckwith
pushed a commit
that referenced
this pull request
Mar 1, 2013
Fixed the bug in GeneralOptions where is wasn't setting the offset and sort parameters
|
Thank you for finding this and fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a simple copy 'n' paste bug. The code in
GeneralOptions.GetParameters is checking against limit.HasValue for
limit, offset, and sort. Updated to check offset.HasValue for offset,
and sort.HasValue for sort.