fixed the forever hang problem on GetBusiness call as the TCS wasn't …

…set on error cases.

.gitignore

@@ -49,3 +49,4 @@ TestResults/*
 packages/
 _ReSharper.YelpSharp/
 Samples/packages
+*.user

YelpSharp/Yelp.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
+using System.Linq;
+using System.Net;
 using RestSharp;
 using RestSharp.Authenticators;
 using YelpSharp.Data;
@@ -127,9 +128,23 @@ protected Task<T> makeRequest<T>(string area, string id, Dictionary<string, stri
 
  var tcs = new TaskCompletionSource<T>();
  var handle = client.ExecuteAsync(request, response =>
- {
- var results = JsonConvert.DeserializeObject<T>(response.Content);
- tcs.SetResult(results);
+ {
+ if(response.StatusCode == HttpStatusCode.NotFound)
+ {
+ tcs.SetResult(default(T));
+ }
+ else
+ {
+ try
+ {
+ T results = JsonConvert.DeserializeObject<T>(response.Content);
+ tcs.SetResult(results);
+ }
+ catch (Exception ex)
+ {
+ tcs.SetException(ex);
+ }
+ }
  });
 
  return tcs.Task;

YelpSharpTests/ErrorTests.cs

@@ -1,8 +1,10 @@
 using System;
-using System.Configuration;
+using System.Configuration;
+using System.Threading.Tasks;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
-using YelpSharp;
+using YelpSharp;
+using YelpSharp.Data;
 using YelpSharp.Data.Options;
 
 namespace YelpSharpTests
@@ -121,7 +123,15 @@ public void ErrorTest_UNSPECIFIED_LOCATION()
  Assert.IsTrue(results.error != null);
  Assert.IsTrue(results.error.id == YelpSharp.Data.ErrorId.UNSPECIFIED_LOCATION);
  Console.WriteLine(results);
- } 
-
+ }
+
+ [TestMethod]
+ public void ErrorTest_UNAVAILABLE_BUSINESS()
+ {
+ Yelp y = new Yelp(Config.Options);
+ Business business = y.GetBusiness("foo-bar").Result;
+
+ Assert.IsNull(business);
+ }
  }
 }

YelpSharpTests/LocationTests.cs

@@ -249,6 +249,5 @@ public void ErrorTest_UNSPECIFIED_LOCATION()
  Assert.IsTrue(results.error.id == YelpSharp.Data.ErrorId.UNSPECIFIED_LOCATION);
  Console.WriteLine(results);
  }
-
  }
 }