Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor configuration and settings #72

Merged
merged 28 commits into from
Oct 29, 2023

Conversation

JurgenR
Copy link
Owner

@JurgenR JurgenR commented Oct 6, 2023

Closes #1
Closes #66

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Test Results

583 tests   - 24   583 ✔️  - 24   5s ⏱️ -1s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 99781a5. ± Comparison against base commit a47ff62.

This pull request removes 68 and adds 44 tests. Note that renamed tests count towards both.
tests.component.test_component_network.TestComponentNetwork ‑ test_initPeerConnection_ConnectToPeerFailed
tests.component.test_component_network.TestComponentNetwork ‑ test_initPeerConnection_ConnectToPeerSuccessful
tests.component.test_component_network.TestComponentNetwork ‑ test_initPeerConnection_withIpPort_success
tests.component.test_component_network.TestComponentNetwork ‑ test_initPeerConnection_withUsername_success
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeDownloadSpeed_limitedToLimited_shouldKeepBucket
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeDownloadSpeed_limitedToUnlimited_shouldChangeLimiter
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeDownloadSpeed_unlimitedToLimited_shouldChangeLimiter
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeUploadSpeed_limitedToLimited_shouldKeepBucket
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeUploadSpeed_limitedToUnlimited_shouldChangeLimiter
tests.component.test_component_network.TestComponentNetworkLimiter ‑ test_whenChangeUploadSpeed_unlimitedToLimited_shouldChangeLimiter
…
tests.unit.protocol.test_messages.TestRoomSearch ‑ test_RoomSearch_Request_deserialize
tests.unit.protocol.test_messages.TestRoomSearch ‑ test_RoomSearch_Request_serialize
tests.unit.room.test_room_manager.TestRoomManager ‑ test_getJoinedRooms
tests.unit.room.test_room_manager.TestRoomManager ‑ test_getOperatedRooms
tests.unit.room.test_room_manager.TestRoomManager ‑ test_getOwnedRooms
tests.unit.room.test_room_manager.TestRoomManager ‑ test_getPrivateRooms
tests.unit.room.test_room_manager.TestRoomManager ‑ test_getPublicRooms
tests.unit.room.test_room_manager.TestRoomManager ‑ test_onChatRoomMessage_shouldEmitEvent
tests.unit.room.test_room_manager.TestRoomManager ‑ test_onJoinRoom_shouldUpdateRoomAndUsers
tests.unit.room.test_room_manager.TestRoomManager ‑ test_onLeaveRoom_shouldUpdateRoomAndUsers
…

♻️ This comment has been updated with latest results.

@JurgenR JurgenR merged commit 23429b8 into main Oct 29, 2023
5 checks passed
@JurgenR JurgenR deleted the feat/refactor-config-settings branch November 28, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Revisit Configuration / Settings Startup scenarios implementation
1 participant