Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revisit user tracking #56

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: revisit user tracking #56

merged 2 commits into from
Sep 25, 2023

Conversation

JurgenR
Copy link
Owner

@JurgenR JurgenR commented Sep 25, 2023

Closes #52

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Test Results

607 tests  +15   607 ✔️ +15   3s ⏱️ -1s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit f78435f. ± Comparison against base commit b6a1697.

This pull request removes 3 and adds 18 tests. Note that renamed tests count towards both.
tests.unit.test_server_manager.TestServerManager ‑ test_untrackUser_userTracked_shouldSendRemoveUser
tests.unit.test_state.TestState ‑ test_whenExistingUser_shouldReturnUser
tests.unit.test_state.TestState ‑ test_whenMissingUser_shouldCreateAndReturnUser
tests.unit.test_model.TestModelChatMessage ‑ test_isServerMessage[server-False-False]
tests.unit.test_model.TestModelChatMessage ‑ test_isServerMessage[server-True-True]
tests.unit.test_model.TestModelChatMessage ‑ test_isServerMessage[user-False-False]
tests.unit.test_model.TestModelChatMessage ‑ test_isServerMessage[user-True-False]
tests.unit.test_server_manager.TestServerManager ‑ test_onChatPrivateMessage_shouldSendAckAndEmitEvent
tests.unit.test_server_manager.TestServerManager ‑ test_onJoinRoom_shouldUpdateRoomAndUsers
tests.unit.test_server_manager.TestServerManager ‑ test_onLeaveRoom_shouldUpdateRoomAndUsers
tests.unit.test_server_manager.TestServerManager ‑ test_untrackUser_addUserFlagRemains_shouldNotSendRemoveUser
tests.unit.test_server_manager.TestServerManager ‑ test_untrackUser_lastAddUserFlag_shouldSendRemoveUser
tests.unit.test_server_manager.TestServerManager ‑ test_untrackUser_lastAddUserFlag_shouldSendRemoveUserAndNotSetStatusUnknown
…

♻️ This comment has been updated with latest results.

@JurgenR JurgenR merged commit c7a5930 into main Sep 25, 2023
5 checks passed
@JurgenR JurgenR deleted the feat/revisit-user-tracking branch November 28, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Status: revisit implementation
1 participant