This repository has been archived by the owner on Aug 3, 2022. It is now read-only.
Fix two bugs. One with the toggle behavior of the switch, and one with the height of the switch. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the off state, if you click on the label the switch does not toggle. This is because the offset is non-zero, which makes the difference non-zero, which makes switch behave as if it’s been dragged to the off state. The fix is to only calculate the state based on the difference if the switch was dragged. And it’s only dragged if the mouse has moved at some point after the initial dragStart. I took a look at the original bootstrap switch and it’s how it behaves too.
When using the switch, I get a massive height. It’s the same as the issue reported here: Bttstrp#360 As I understand it, height specifies the height of an element relative to its parent container, so 100% is the same height as its parent. https://www.w3.org/TR/CSS21/visudet.html#propdef-height However, I think it makes sense for a switch to be defined by its internal height (as dictated by its size / content).
|
Seconded. @timchang, I'm going to use your fork for now. |
Julusian
added a commit
that referenced
this pull request
Jan 13, 2016
Fix two bugs. One with the toggle behavior of the switch, and one with the height of the switch.
|
Sorry for taking to long to merge this. |
|
No worries. Hope you had an enjoy holiday. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.