Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using LibCURL_jll / MozillaCACerts_jll #75

Merged
merged 6 commits into from
May 21, 2020
Merged

Conversation

omus
Copy link
Collaborator

@omus omus commented Feb 14, 2020

I used FTPClient.jl with these changes and the tests there did pass

@omus
Copy link
Collaborator Author

omus commented Feb 14, 2020

CI failure on Linux is returning CURLE_SSL_CACERT. This failure was previously expected on FreeBSD, macOS, and Windows but it is now also happening on Linux.

cc: @staticfloat

@omus
Copy link
Collaborator Author

omus commented Feb 14, 2020

Related to: #57

@staticfloat
Copy link
Contributor

Can you re-run CI and see if it fails with the latest LibCURL jll?

@ViralBShah
Copy link

Does the Julia build pull libcurl from this jll? Just like openblas_jll, can we have packages that need libcurl_jll to simply use the one that ships with Julia itself?

@staticfloat
Copy link
Contributor

That's part of what JuliaLang/julia#35193 will provide

@aviks
Copy link
Member

aviks commented May 1, 2020

I submitted a change to LibCURL_jll to store the mozilla ca bundle. It'll require some change here which I'll do once the jll update is pushed and registered, but hopefully that'll solve the cert issues here (and at many other places)

@omus
Copy link
Collaborator Author

omus commented May 20, 2020

I've pulled in the commits from #78 to get this PR to pass (I don't have access to update the branch for #78)

@omus omus changed the title Switch to using LibCURL_jll Switch to using LibCURL_jll / MozillaCACerts_jll May 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #75 into master will decrease coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #75      +/-   ##
=========================================
- Coverage    7.51%   6.81%   -0.71%     
=========================================
  Files           2       2              
  Lines         133     132       -1     
=========================================
- Hits           10       9       -1     
  Misses        123     123              
Impacted Files Coverage Δ
src/LibCURL.jl 36.36% <ø> (-5.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7282455...5439cbe. Read the comment docs.

@omus
Copy link
Collaborator Author

omus commented May 20, 2020

Everything looks good now. I want to validate these changes with FTPClient.jl but I'll need to do that tomorrow.

Project.toml Outdated Show resolved Hide resolved
@aviks
Copy link
Member

aviks commented May 21, 2020

I want to validate these changes with FTPClient.jl

Yeah, it's worth checking that the jll binary does ftp correctly. (BTW, it should also do http2 now)

I tested these changes with SMTPClient.jl (which also had numerous reports of certificate problems), and they are all fixed with this change, waiting for a tag here.

Project.toml Outdated Show resolved Hide resolved
@omus
Copy link
Collaborator Author

omus commented May 21, 2020

I want to validate these changes with FTPClient.jl

Changes work fine with FTPClient.jl. I did notice a failure but I can reproduce the failure without this PR.

@omus omus merged commit 979c346 into master May 21, 2020
@omus omus deleted the cv/libcurl_jll branch May 21, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants