Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of ContextVariablesX.jl #93

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Conversation

omus
Copy link
Member

@omus omus commented Oct 14, 2021

Reverts the changes from #91 which introduced the use of ContextVariablesX.jl. Unfortunately this package doesn't work as expected when the logger is changed resulting in unexpected breakage. I've included the tests from #91 here.

Fixes #92. Re-opens #89.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #93 (791ecf8) into master (4572de4) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   83.72%   84.12%   +0.40%     
==========================================
  Files           6        6              
  Lines         129      126       -3     
==========================================
- Hits          108      106       -2     
+ Misses         21       20       -1     
Impacted Files Coverage Δ
src/Mocking.jl 45.45% <ø> (ø)
src/mock.jl 81.25% <100.00%> (+2.46%) ⬆️
src/patch.jl 100.00% <100.00%> (ø)
src/expr.jl 100.00% <0.00%> (ø)
src/dispatch.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4572de4...791ecf8. Read the comment docs.

@omus
Copy link
Member Author

omus commented Oct 14, 2021

Will add a test for #92

omus added a commit to omus/General that referenced this pull request Oct 14, 2021
@omus omus merged commit 0efbdfb into master Oct 14, 2021
@omus omus deleted the cv/revert-contextvariables branch October 14, 2021 16:18
ericphanson pushed a commit to JuliaRegistries/General that referenced this pull request Oct 14, 2021
@omus omus mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch ignored on v0.7.4
1 participant