Remove special branch for some julia v1.6.0-DEV versions #149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 76.96% 77.14% +0.18%
==========================================
Files 11 11
Lines 725 722 -3
==========================================
- Hits 558 557 -1
+ Misses 167 165 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -105,7 +105,7 @@ end | |||
| is_foreign(@nospecialize(T::TypeVar), pkg::Base.PkgId) = is_foreign(T.ub, pkg) | |||
|
|
|||
| # Before 1.7, Vararg was a UnionAll, so the UnionAll method will work | |||
| @static if VERSION >= v"1.7" | |||
| @static if VERSION >= v"1.7-" | |||
There was a problem hiding this comment.
Huh, what is the difference in behavior here?
There was a problem hiding this comment.
Ah, sorry, I missed that in the description.
The new comparison is also true for all beta's and rc's before the 1.7 release. As the behavior tested here was changed before the 1.7 feature freeze, this should be changed, as it currently breaks tests on e.g. 1.7.0-beta1 and 1.7.0-rc3. Changing this fixes it.
There was a problem hiding this comment.
OK, so this is for a hypothetical scenario were someone is today using a beta version of an outdated non-LTS Julia version... got it ;-)
fc14c4e
to
420a1fe
Compare
This branch contains some special code for versions between JuliaLang/julia#36962 (
v1.6.0-DEV.816) and JuliaLang/julia#37484 (v1.6.0-DEV.875).I think Aqua should not need to support DEV builds that are more than 2 years old.
Thus I propose to remove the branch.