Add an EventTable type that supports the Tables interface
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Kaplan-Meier and Nelson-Aalen compute the same set of basic counts at each unique time prior to computing their respective quantities of interest. The counts have a notably table-like format, so much so that they can implement the Tables.jl interface with minimal effort. Credit for the idea of integration with Tables.jl goes entirely to Tyler Beacon, author of PR #25, who has been added as a co-author of this commit. Co-Authored-By: Tyler Beason <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 99.58% 99.69% +0.10%
==========================================
Files 6 6
Lines 240 323 +83
==========================================
+ Hits 239 322 +83
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Kaplan-Meier and Nelson-Aalen compute the same set of basic counts at each unique time prior to computing their respective quantities of interest. The counts have a notably table-like format, so much so that they can implement the Tables.jl interface with minimal effort.
As a follow-up, I'll refactor
KaplanMeierandNelsonAalento useEventTableunder the hood and clean out all the stuff that's now redundant with theEventTablemachinery.Credit for the idea of integration with Tables.jl goes entirely to Tyler Beason, author of #25, who has been added as a co-author of this commit.