Revert "Prepare standalone package, step 2 (#128)" #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 14438ab. `mean` will not be moved to Base as Statistics will remain an (upgradable) stdlib. Keep version at 1.11.0 though.
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bkamins
reviewed
Sep 9, 2023
src/Statistics.jl
Outdated
| end | ||
|
|
||
| median(r::AbstractRange{<:Real}) = mean(r) |
There was a problem hiding this comment.
why is this definition moved here?
There was a problem hiding this comment.
In the commit this reverts I had moved it outside of the if as we had to define it even if mean was defined in Base. I'm just moving it to its original place. But yeah the new one is more logical so maybe we could live it there.
There was a problem hiding this comment.
For me the location near other median methods is more logical.
bkamins
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 14438ab.
meanwill not be moved to Base as Statistics will remain an (upgradable) stdlib.Keep version at 1.11.0 though.