Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Julia 1.5 random number generators are not guaranteed to provide the same sequence of numbers for a given seed (see here).
This PR replaced the global rng used in tests with a StableRNG called
testrng
and uses it everywhere.Turns out that was not enough because Lasso.jl has a RandomCoefficientIterator that uses its own RNG.
So to get deterministic test, I also add the ability to specify an
rng
in the call tofit(...; rng=StableRNG(123))
.Tests now seem to pass on 1.5.
Closes #48