Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Censored distribution #1470

Merged
merged 138 commits into from
Jan 31, 2022
Merged
Changes from 1 commit
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
2d2b82c
Implement Censored
sethaxen Jan 11, 2022
eba2355
Export Censored and censored
sethaxen Jan 11, 2022
12786be
Apply suggestions from code review
sethaxen Jan 12, 2022
ad80bc0
Reorganize code
sethaxen Jan 12, 2022
b9a9d23
Move check to constructor
sethaxen Jan 12, 2022
066d15e
Make newline optional
sethaxen Jan 12, 2022
c111081
Reformat
sethaxen Jan 12, 2022
ec24f3c
Improve show method
sethaxen Jan 12, 2022
97db2f5
Add checks for finiteness
sethaxen Jan 12, 2022
744133b
Implement expectations
sethaxen Jan 12, 2022
1ffed7a
Satisfy required params behavior
sethaxen Jan 12, 2022
e9b37cc
Overload truncated for DiscreteUniform
sethaxen Jan 12, 2022
805211c
Don't re-censor
sethaxen Jan 12, 2022
21194d6
Handle case where censored to single point
sethaxen Jan 12, 2022
74d5228
Reformat
sethaxen Jan 12, 2022
1123bd1
Add censored docs page
sethaxen Jan 12, 2022
d6f293c
Update censored.md
sethaxen Jan 12, 2022
3d5ae7d
Document censored
sethaxen Jan 12, 2022
c555075
Add truncated DiscreteUniform tests
sethaxen Jan 12, 2022
d9a1ff3
Add un-called truncated_uniform test suite
sethaxen Jan 12, 2022
ae5fa7c
Skip check for DiscreteUniform
sethaxen Jan 12, 2022
3dfbd72
Add loglikelihood
sethaxen Jan 13, 2022
e9aa316
Include bounds in support
sethaxen Jan 13, 2022
da70bc9
Update src/truncated/discrete_uniform.jl
sethaxen Jan 13, 2022
a6204b4
Remove unnecessary checks for finiteness
sethaxen Jan 13, 2022
ea7e77a
Swap order of checks
sethaxen Jan 13, 2022
2609bd0
Update censored.jl
sethaxen Jan 13, 2022
40afb67
Support using missing to specify unbounded
sethaxen Jan 14, 2022
d8830e1
Merge branch 'master' into censored
sethaxen Jan 14, 2022
5c21d83
Apply suggestions from code review
sethaxen Jan 14, 2022
36c3e7b
Improve docstrings
sethaxen Jan 14, 2022
2b8c621
Reformat
sethaxen Jan 14, 2022
7ac66f6
Rewrap signature
sethaxen Jan 14, 2022
ba1cdd3
Use ismissing everywhere
sethaxen Jan 14, 2022
595c227
Reformat
sethaxen Jan 14, 2022
9760a93
Fix maximum
sethaxen Jan 14, 2022
abfca6d
Fix support check
sethaxen Jan 14, 2022
8be8573
Support fields that are equivalent
sethaxen Jan 14, 2022
f8c5171
Add basic censored tests
sethaxen Jan 14, 2022
5ef0974
Apply suggestions from code review
sethaxen Jan 14, 2022
a40b2b8
Resolve ambiguity
sethaxen Jan 14, 2022
791795c
Resolve ambiguity
sethaxen Jan 14, 2022
06db648
Use equivalence check for missing everywhere
sethaxen Jan 15, 2022
f140cb6
Fix ccdf and logccdf
sethaxen Jan 15, 2022
f21afba
Better construct mixture equivalent
sethaxen Jan 15, 2022
90dba2d
Implement mixture model for continuous censored dists
sethaxen Jan 15, 2022
a972a55
Add uniform tests
sethaxen Jan 15, 2022
5a383ea
Enhance discrete uniform tests
sethaxen Jan 15, 2022
14e4f79
Add Poisson tests
sethaxen Jan 15, 2022
3f48e7f
Fix implementation of entropy
sethaxen Jan 16, 2022
66f4735
Test mean/std of censored Poisson
sethaxen Jan 16, 2022
29be974
Add normal tests
sethaxen Jan 16, 2022
ad6d76a
Remove unused methods
sethaxen Jan 16, 2022
7391d13
Test bounds check
sethaxen Jan 16, 2022
5a9b598
Add log-likelihood test
sethaxen Jan 16, 2022
4ec91a0
Add test for censorship to empty interval
sethaxen Jan 16, 2022
625d8d7
Support censorship to empty intervals
sethaxen Jan 16, 2022
a241067
Add comments about expectations
sethaxen Jan 16, 2022
247d52b
Add more checks for inferrability
sethaxen Jan 16, 2022
e29bdb9
Test explicit expectations for DiscreteUniform
sethaxen Jan 16, 2022
cc19906
Rewrite censored docstring
sethaxen Jan 16, 2022
7219dab
Indicate interval censoring
sethaxen Jan 16, 2022
f55d7e0
Update docs/src/index.md
sethaxen Jan 16, 2022
6e11add
Apply suggestions from code review
sethaxen Jan 16, 2022
f926b62
Don't use now-deleted function
sethaxen Jan 16, 2022
cc4c3eb
Fix tes for new params definition
sethaxen Jan 16, 2022
5630be0
Make loglikelihood type-stable
sethaxen Jan 16, 2022
b296aa9
Add comment about equivalence check
sethaxen Jan 16, 2022
67c0259
Unabbreviate name
sethaxen Jan 16, 2022
e444b80
Remove inlines
sethaxen Jan 16, 2022
87b68c2
Add plaintext mimetype
sethaxen Jan 16, 2022
a85bdca
Add more truncated DiscreteUniform tests
sethaxen Jan 16, 2022
f8bb1f7
Add xexpx
sethaxen Jan 17, 2022
804eba9
Compute probabilities on log scale
sethaxen Jan 17, 2022
bed8267
Clarify variable names
sethaxen Jan 17, 2022
73e5615
Eliminate deprecation warnings
sethaxen Jan 17, 2022
ff6d487
Fix inferrability error
sethaxen Jan 17, 2022
3f79d2a
Reformat
sethaxen Jan 19, 2022
9688143
Add check_args keyword
sethaxen Jan 19, 2022
d7b8eef
Merge branch 'master' into censored
sethaxen Jan 19, 2022
d778052
Promote each xi
sethaxen Jan 19, 2022
bb33140
Fix checking of args
sethaxen Jan 19, 2022
d1468a0
Use bounds also to set types
sethaxen Jan 19, 2022
98c4b0b
Use check_args macro
sethaxen Jan 19, 2022
70c2cd3
Check for ArgumentError
sethaxen Jan 19, 2022
4547804
Use eps to detect empty truncation
sethaxen Jan 19, 2022
d2e20f4
Use more accurate variable name
sethaxen Jan 19, 2022
ac3b799
Use oneunit
sethaxen Jan 19, 2022
f024f45
Improve type-stability everywhere
sethaxen Jan 19, 2022
768cfca
Exhaustively test for type-inferribility
sethaxen Jan 19, 2022
16633c6
Remove now-unneeded test
sethaxen Jan 19, 2022
72a6efb
Revert "Improve type-stability everywhere"
sethaxen Jan 20, 2022
f487cc6
Add convenient types
sethaxen Jan 21, 2022
13b016f
Use convenient types
sethaxen Jan 21, 2022
f9457db
Add missing check for in support of uncensored
sethaxen Jan 21, 2022
e5e3246
Avoid promoting inputs based on bounds
sethaxen Jan 21, 2022
5ac7dc7
Avoid promoting inputs based on bounds
sethaxen Jan 21, 2022
6c0c789
Separate expectations to own methods
sethaxen Jan 21, 2022
f135580
Check in interval first
sethaxen Jan 21, 2022
19a331f
Don't promote input types
sethaxen Jan 21, 2022
c712050
Apply suggestions from code review
sethaxen Jan 21, 2022
b4a1dda
Remove lingering reference to udnefined type
sethaxen Jan 21, 2022
0fb63a9
Docstring fixes
sethaxen Jan 21, 2022
286e8e6
Consistently use d0 for uncensored
sethaxen Jan 21, 2022
eb20f91
Use nothing instead of missing
sethaxen Jan 21, 2022
386f779
Reorganize
sethaxen Jan 21, 2022
a11f0e8
Add keyword constructor
sethaxen Jan 21, 2022
18085ac
Document and promote keyword constructors
sethaxen Jan 21, 2022
125dee4
Use keyword arguments in show
sethaxen Jan 21, 2022
72e6135
Don't use isnothing in tests
sethaxen Jan 21, 2022
ddde5cd
Don't print nothing
sethaxen Jan 21, 2022
ccef571
Export Censored
sethaxen Jan 21, 2022
7af5e83
Once sentence per line
sethaxen Jan 21, 2022
f0342a0
Docstring improvements
sethaxen Jan 21, 2022
f155cda
Fix variable rendering
sethaxen Jan 21, 2022
d70e518
Add missing comma
sethaxen Jan 21, 2022
6ed1e96
Revert "Export Censored"
sethaxen Jan 21, 2022
399d9bf
Prepend with module so docs build
sethaxen Jan 21, 2022
6062f7f
Document with module prepended
sethaxen Jan 21, 2022
e9d93a4
Use function ... end syntax
sethaxen Jan 24, 2022
d2759ad
Apply suggestions from code review
sethaxen Jan 25, 2022
c584c85
LeftCensored ⇌ RightCensored
sethaxen Jan 25, 2022
e41b221
Apply suggestions from code review
sethaxen Jan 25, 2022
0273192
Introduce xexpy
sethaxen Jan 25, 2022
63b03f0
Remove test for no-longer-supported case
sethaxen Jan 25, 2022
f323ae1
Simplify implementations
sethaxen Jan 25, 2022
f4e3aa0
Rearrange left before right
sethaxen Jan 25, 2022
461c19a
Merge branch 'master' into censored
sethaxen Jan 25, 2022
cc4051b
Increment version number
sethaxen Jan 25, 2022
fcf9fbc
Use information theory notation for entropy
sethaxen Jan 26, 2022
c89458d
Use d0 notation
sethaxen Jan 26, 2022
b33f0f4
Add header
sethaxen Jan 26, 2022
36f2430
Test infinite bounds just in case
sethaxen Jan 26, 2022
ba60409
Merge branch 'master' into censored
mschauer Jan 31, 2022
68e5de2
Apply suggestions from code review
sethaxen Jan 31, 2022
8308cda
Merge branch 'master' into censored
sethaxen Jan 31, 2022
a1e8fe3
Add and test partially truncated overloads for discrete uniform
sethaxen Jan 31, 2022
f632f10
Update src/censored.jl
sethaxen Jan 31, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformat
  • Loading branch information
sethaxen committed Jan 12, 2022
commit 74d5228128519b7523cf118febae034bb455495e
4 changes: 1 addition & 3 deletions src/censored.jl
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,4 @@ end

#### Sampling

function rand(rng::AbstractRNG, d::Censored)
return clamp(rand(rng, d.uncensored), d.lower, d.upper)
end
rand(rng::AbstractRNG, d::Censored) = clamp(rand(rng, d.uncensored), d.lower, d.upper)