-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: LSurv v1.0.2 #91190
New package: LSurv v1.0.2 #91190
Conversation
JuliaRegistrator
commented
Sep 11, 2023
- Registering package: LSurv
- Repository: https://github.com/alexpkeil1/LSurvival.jl
- Created by: @alexpkeil1
- Version: v1.0.2
- Commit: 2192f6ef27d0dbe5f2eeb8a2f0f055ecff28562c
- Reviewed by: @alexpkeil1
- Reference: Register alexpkeil1/LSurvival.jl#10 (comment)
- Description: Survival analysis functions that allow left truncation and weighting, including Aalen-Johansen, Kaplan-Meier, and Cox proportional hazards regression
UUID: edbbf5c1-874b-40a5-8c9f-d8fc918aacaa Repo: https://github.com/alexpkeil1/LSurvival.jl.git Tree: 4cc7fd99021713ffe2acb26686d60901bcc72b21 Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
[noblock] LSurvival.jl is a better name |
I also prefer LSurvival.jl. The module was named LSurvival until this morning. It did not auto-merge because it was too similar to Survival.jl. If I rename to "LSurvival.jl" - can I request a manual merge? |
I re-submitted under "LSurvival" here: |
No guarantees, there seem to be a lot of these survival packages... why not contribute to the other ones instead? |
Good point, but there wasn't a good path with any of the existing repositories. I looked at Survival.jl it looked like it would have required a significant re-factoring to accomodate some features I consider necessary in applied work (e.g. preferred methods to handle tied event times via the Efron partial likelihood, observation weights, residuals, and handling of left truncation) of the main package functions. AcceleratedFailure.jl that is being ported into Survival.jl, but it has the same limitations. EventHistory.jl hasn't been updated in 5 years and lacks Efron's partial likelihood. SurvivalAnalysis.jl looks like it's not being updated and is missing a lot of basic functionality (e.g. Cox models) |
If you plan to be more comprehensive than any of the others and effectively replace them, its ok. But often in reality we just end up with 4 incomplete packages instead |
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock] |