Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: LSurv v1.0.2 #91190

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: edbbf5c1-874b-40a5-8c9f-d8fc918aacaa
Repo: https://github.com/alexpkeil1/LSurvival.jl.git
Tree: 4cc7fd99021713ffe2acb26686d60901bcc72b21

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Repo URL does not end with /name.jl.git, where name is the package name

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@rafaqz
Copy link
Contributor

rafaqz commented Sep 11, 2023

[noblock] LSurvival.jl is a better name

@alexpkeil1
Copy link

I also prefer LSurvival.jl. The module was named LSurvival until this morning. It did not auto-merge because it was too similar to Survival.jl.

If I rename to "LSurvival.jl" - can I request a manual merge?

@alexpkeil1
Copy link

[noblock] LSurvival.jl is a better name

I re-submitted under "LSurvival" here:
#91198

@rafaqz
Copy link
Contributor

rafaqz commented Sep 11, 2023

No guarantees, there seem to be a lot of these survival packages... why not contribute to the other ones instead?

@alexpkeil1
Copy link

Good point, but there wasn't a good path with any of the existing repositories. I looked at Survival.jl it looked like it would have required a significant re-factoring to accomodate some features I consider necessary in applied work (e.g. preferred methods to handle tied event times via the Efron partial likelihood, observation weights, residuals, and handling of left truncation) of the main package functions.

AcceleratedFailure.jl that is being ported into Survival.jl, but it has the same limitations. EventHistory.jl hasn't been updated in 5 years and lacks Efron's partial likelihood. SurvivalAnalysis.jl looks like it's not being updated and is missing a lot of basic functionality (e.g. Cox models)

@rafaqz
Copy link
Contributor

rafaqz commented Sep 11, 2023

If you plan to be more comprehensive than any of the others and effectively replace them, its ok. But often in reality we just end up with 4 incomplete packages instead

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Oct 12, 2023
@github-actions
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Oct 19, 2023
@github-actions github-actions bot deleted the registrator-lsurv-edbbf5c1-v1.0.2-24b11deed0 branch October 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants