Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: StaticArrays v0.12.5 #23652

Merged
merged 1 commit into from
Oct 28, 2020
Merged

New version: StaticArrays v0.12.5 #23652

merged 1 commit into from
Oct 28, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 26, 2020 •
edited
Loading

JuliaRegistrator referenced this pull request in JuliaArrays/StaticArrays.jl Oct 26, 2020
@andyferris
Bump version to 0.12.5
9f2fa89
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@c42f
Copy link
Contributor

c42f commented Oct 26, 2020 •
edited
Loading

Hold on. I think we've got some breaking changes; we should review upstream before merging this.

@JuliaRegistrator
New version: StaticArrays v0.12.5
bba7882 
UUID: 90137ffa-7385-5640-81b9-e52037218182
Repo: https://github.com/JuliaArrays/StaticArrays.jl.git
Tree: da4cf579416c81994afd6322365d00916c79b8ae

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/staticarrays/90137ffa/v0.12.5 branch from 6f849f3 to bba7882 Compare October 28, 2020 00:20
JuliaRegistrator referenced this pull request in JuliaArrays/StaticArrays.jl Oct 28, 2020
@andyferris
Bump version to 0.12.5
6bbf550
@andyferris andyferris mentioned this pull request Oct 28, 2020
Merged
@Keno
Copy link
Contributor

Keno commented Oct 28, 2020

This now points to a version of StaticArrays without the breaking changes. I'd like @c42f to confirm that this addresses his concerns and if so, we need to merge this manually, since automatic merging is otherwise blocked.

@c42f
Copy link
Contributor

c42f commented Oct 28, 2020 •
edited
Loading

Yes, please merge this! I've verified that the tree hash da4cf579416c81994afd6322365d00916c79b8ae is the correct one according to our new release branch upstream. Thanks @andyferris :-)

@fredrikekre fredrikekre merged commit 6c6a46d into master Oct 28, 2020
@fredrikekre fredrikekre deleted the registrator/staticarrays/90137ffa/v0.12.5 branch October 28, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaRegistrator @c42f @Keno @fredrikekre