Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FirstOrderddt -> SecondOrderddt #646

Merged
merged 3 commits into from
Jul 3, 2022
Merged

Rename FirstOrderddt -> SecondOrderddt #646

merged 3 commits into from
Jul 3, 2022

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 3, 2022

No description provided.

@schillic schillic requested a review from mforets July 3, 2022 16:22
mforets
mforets approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recall if we renamed the method in the arxiv version of the review article as well?

test/algorithms/LGG09.jl Outdated Show resolved Hide resolved
test/algorithms/LGG09.jl Outdated Show resolved Hide resolved
schillic and others added 2 commits July 3, 2022 18:53
@schillic
Copy link
Member Author

schillic commented Jul 3, 2022

Do you recall if we renamed the method in the arxiv version of the review article as well?

We did not.

@mforets mforets mentioned this pull request Jul 3, 2022
Open
@schillic
Copy link
Member Author

schillic commented Jul 3, 2022

Should we merge this or do you want to sync?

@mforets
Copy link
Member

mforets commented Jul 3, 2022

I think we can merge this and sync later; i added #647 as a reminder.

@mforets mforets merged commit 4000e74 into master Jul 3, 2022
@mforets mforets deleted the schillic/secondorder branch July 3, 2022 21:53
schillic added a commit that referenced this pull request Jul 4, 2022
@schillic
update docstring for #646
455f46f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schillic @mforets