Fix Interval setvrep and speed up redundancy removal #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When arguments where given, the redundancy removal or linearity detection was using the default implementation and not using the fact that intervals have no redundancy by construction. This was hitting another bug with setvrep and resetvrep which are not fixed as well.
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 89.00% 89.11% +0.11%
==========================================
Files 37 37
Lines 3037 3051 +14
==========================================
+ Hits 2703 2719 +16
+ Misses 334 332 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arguments where given, the redundancy removal or linearity detection was using the default implementation and not using the fact that intervals have no redundancy by construction.
This was hitting another bug with
setvrep!andresetvrep!which are not fixed as well.Closes #298